Skip to content

Conversation

@hramezani
Copy link
Member

  • Add NoDecode and ForceDecode annotations
  • Add enable_decoding config with the default value of True
  • Add docs

Please let me know if you have better suggestion about the names

@hramezani hramezani force-pushed the improve-value-parsing branch from 5295989 to ad64130 Compare December 3, 2024 13:33
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:

  • [Vv]alidator

@hramezani hramezani force-pushed the improve-value-parsing branch from ad64130 to a652163 Compare December 3, 2024 13:40
Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM.

@hramezani hramezani force-pushed the improve-value-parsing branch from a652163 to 5748f06 Compare December 4, 2024 08:52
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 files reviewed, 1 total issue(s) found.

Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:

  • [Cc]onfig

Note: We resolved prior Hyperlint review comments because:

We updated our inline suggestion AI.

We do this to avoid keeping outdated or irrelevant comments around. We'll leave a new review with current comments below.

Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:

  • [Vv]alidator
  • [Cc]onfig

@hramezani hramezani merged commit 3667aed into main Dec 9, 2024
23 checks passed
@hramezani hramezani deleted the improve-value-parsing branch December 9, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants